suddjian commented on pull request #13306: URL: https://github.com/apache/superset/pull/13306#issuecomment-823531156
I appreciate the inconvenience of the performance hit, but I don't think a revert is the appropriate response in this case, for the following reasons. - The plan to skip cache support for now and follow up later was agreed upon by a member of the Airbnb team (as documented above) - A 25% performance hit, while inconvenient, is not nearly as critical as, for example, a broken page or security issue - The community was not made aware of this issue before the revert occurred I'm happy to work with folks on moving forward with adding performance improvements such as a cache, but reverting this change makes the work of developers significantly harder as we have to deal with substantially more source control branching complexities. Considering the circumstances I think a conversation should have been at least attempted. Adding a feature flag to this project would be impractical, as various details need to change about how the app is loaded and the constant FF checks needed would make issues more likely to occur. Optimizing the endpoints seems more practical. @ktmud do you have any availability to work together on a caching solution for this problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
