john-bodley commented on a change in pull request #14255:
URL: https://github.com/apache/superset/pull/14255#discussion_r617092183
##########
File path: tests/db_engine_specs/hive_tests.py
##########
@@ -209,7 +209,7 @@ def
test_create_table_from_csv_if_exists_fail_with_schema(mock_table, mock_g):
@mock.patch(
"superset.db_engine_specs.hive.config",
- {**app.config, "CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC": lambda *args: True},
+ {**app.config, "CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC": lambda *args: ""},
Review comment:
The `CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC` function returns a `str` and not
a `boolean`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
