villebro opened a new pull request #14297: URL: https://github.com/apache/superset/pull/14297
### SUMMARY When a query object is using `columns` over `groupby`, the timeseries limit is not applied. This PR changes the timeseries limit to check `groupby_exprs_sans_timestamp` instead of `groupby`, as that's what's actually referenced in the code block. ### BEFORE The timeseries limit (set to 5 here) is ignored:  ### AFTER The timeseries limit applies correctly:  ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
