lelouch77 opened a new pull request #14300:
URL: https://github.com/apache/superset/pull/14300


   ### SUMMARY
   Chart screen: When the URL_IS_TOO_LONG_TO_SHARE scenario occurs, reloading 
the page, goes to the new chart screen
   
   
   ### TEST PLAN
   Create a chart and make changes in form-data until 'URL_IS_TOO_LONG_TO_SHARE 
' scenario appears and save the chart, now reload the page
   Before fix:
   The screen will lose the context and goes to new chart creation screen
   After fix:
   The screen will retain the save chart context, since the slice_id is added 
to URL param
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to