dpgaspar commented on a change in pull request #13521: URL: https://github.com/apache/superset/pull/13521#discussion_r618591135
########## File path: superset/migrations/versions/d416d0d715cc_add_limiting_factor_column_to_query_.py ########## @@ -0,0 +1,72 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""add_limiting_factor_column_to_query_model.py + +Revision ID: d416d0d715cc +Revises: 19e978e1b9c3 +Create Date: 2021-04-16 17:38:40.342260 + +""" + +# revision identifiers, used by Alembic. +revision = "d416d0d715cc" +down_revision = "19e978e1b9c3" + +from enum import Enum + +import sqlalchemy as sa +from alembic import op +from sqlalchemy.dialects import postgresql +from sqlalchemy.dialects.postgresql.base import PGDialect + +limiting_factor = postgresql.ENUM( + "DROPDOWN", + "QUERY", + "NOT_LIMITED", + "QUERY_AND_DROPDOWN", + "UNKNOWN", + name="limitingfactor", +) + + +def upgrade(): + bind = op.get_bind() + if isinstance(bind.dialect, PGDialect): + limiting_factor.create(bind) + with op.batch_alter_table("query") as batch_op: + batch_op.add_column( + sa.Column( + "limiting_factor", + sa.Enum( Review comment: We tend to prefer not using Enums, because they force a new DB migration when a new value is needed, You can still use python `Enum` but use a String on the DB field ########## File path: superset/migrations/versions/d416d0d715cc_add_limiting_factor_column_to_query_.py ########## @@ -0,0 +1,72 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""add_limiting_factor_column_to_query_model.py + +Revision ID: d416d0d715cc +Revises: 19e978e1b9c3 +Create Date: 2021-04-16 17:38:40.342260 + +""" + +# revision identifiers, used by Alembic. +revision = "d416d0d715cc" +down_revision = "19e978e1b9c3" + +from enum import Enum + +import sqlalchemy as sa +from alembic import op +from sqlalchemy.dialects import postgresql +from sqlalchemy.dialects.postgresql.base import PGDialect + +limiting_factor = postgresql.ENUM( + "DROPDOWN", + "QUERY", + "NOT_LIMITED", + "QUERY_AND_DROPDOWN", + "UNKNOWN", + name="limitingfactor", +) + + +def upgrade(): + bind = op.get_bind() + if isinstance(bind.dialect, PGDialect): + limiting_factor.create(bind) + with op.batch_alter_table("query") as batch_op: + batch_op.add_column( + sa.Column( + "limiting_factor", + sa.Enum( + "DROPDOWN", + "QUERY", + "NOT_LIMITED", + "QUERY_AND_DROPDOWN", + "UNKNOWN", + name="limitingfactor", + ), + server_default="UNKNOWN", + ) + ) + + +def downgrade(): + with op.batch_alter_table("query") as batch_op: + batch_op.drop_column("limiting_factor") + bind = op.get_bind() Review comment: This nesting is probably wrong, `bind = op.get_bind` should be unnested -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
