benjreinhart commented on a change in pull request #13970:
URL: https://github.com/apache/superset/pull/13970#discussion_r618601189



##########
File path: Makefile
##########
@@ -0,0 +1,49 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+.PHONY: install superset venv pre-commit
+
+install: venv superset pre-commit
+
+superset:
+       # Install external dependencies
+       pip install -r requirements/local.txt
+
+       # Install Superset in editable (development) mode
+       pip install -e .
+
+       # Create an admin user in your metadata database
+       superset fab create-admin
+
+       # Initialize the database
+       superset db upgrade
+
+       # Create default roles and permissions
+       superset init
+
+       # Load some data to play with
+       superset load-examples
+
+venv:
+       # Create a virtual environment and activate it (recommended)
+       python3 -m venv venv # setup a python3 virtualenv

Review comment:
       Have we considered naming the superset virtual environment something 
other than `venv` (perhaps specific to this application)? This could reduce the 
chance it will conflict with existing virtual environments on folks' machines.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to