rusackas commented on pull request #14184: URL: https://github.com/apache/superset/pull/14184#issuecomment-825141654
 A few little visual details remaining: 1) The padding to the right of the caret got smaller, and does not match the padding on the left of the text 2) There's still like 1px of space between the menu trigger, and the dropdown itself, which is easy to see with the little blue line. 3) The corners of the dropdown list are rounded. I don't mind it on the bottom corners, but the top corners again show the blue a little bit more than I think they should, so maybe we should un-round just those top ones. 4) The list items in the dropdown use do have a faint blue background and gray text... now they stay white, but the text color changes to blue. I don't mind it, but I want @steejay and/or @mihir174 to take a look, so I'll tag this PR with a need for design input. ... there also seem to be an issues with linting that're holding up CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
