etr2460 commented on a change in pull request #14278:
URL: https://github.com/apache/superset/pull/14278#discussion_r618966520



##########
File path: .github/ISSUE_TEMPLATE/sip.md
##########
@@ -6,9 +6,9 @@ labels: "#SIP"
 ---
 
 *Please make sure you are familiar with the SIP process documented*
-(here)[https://github.com/apache/superset/issues/5602]
+(here)[https://github.com/apache/superset/issues/5602]. The SIP number should 
be the next increment from the latest SIP listed 
[here](https://github.com/apache/superset/issues?q=is%3Aissue+label%3Asip).

Review comment:
       i like this wording better, but i'm fine either way
   
   ```suggestion
   (here)[https://github.com/apache/superset/issues/5602]. The SIP number 
should be the next number after the latest SIP listed 
[here](https://github.com/apache/superset/issues?q=is%3Aissue+label%3Asip).
   ```

##########
File path: .github/ISSUE_TEMPLATE/sip.md
##########
@@ -6,9 +6,9 @@ labels: "#SIP"
 ---
 
 *Please make sure you are familiar with the SIP process documented*
-(here)[https://github.com/apache/superset/issues/5602]
+(here)[https://github.com/apache/superset/issues/5602]. The SIP number should 
be the next increment from the latest SIP listed 
[here](https://github.com/apache/superset/issues?q=is%3Aissue+label%3Asip).
 
-## [SIP] Proposal for XXX
+## [SIP-\<number>] Proposal for <title>

Review comment:
       ```suggestion
   ## [SIP-<number>] Proposal for <title>
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to