suddjian commented on a change in pull request #14306:
URL: https://github.com/apache/superset/pull/14306#discussion_r618974088
##########
File path: superset/models/dashboard.py
##########
@@ -242,29 +242,24 @@ def data(self) -> Dict[str, Any]:
@cache_manager.cache.memoize(
# manage cache version manually
- make_name=lambda fname: f"{fname}-v2.1",
+ make_name=lambda fname: f"{fname}-v1.0",
unless=lambda: not is_feature_enabled("DASHBOARD_CACHE"),
)
- def full_data(self) -> Dict[str, Any]:
- """Bootstrap data for rendering the dashboard page."""
- slices = self.slices
- datasource_slices = utils.indexed(slices, "datasource")
- try:
- datasources = {
- # Filter out unneeded fields from the datasource payload
- datasource.uid: datasource.data_for_slices(slices)
- for datasource, slices in datasource_slices.items()
- if datasource
- }
- except (SupersetException, SQLAlchemyError):
- datasources = {}
+ def slices_cached(self) -> List[Slice]:
Review comment:
As discussed in slack, changing `slices` to a property ends up being
kinda sketch so leaving it like this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
