kgabryje commented on a change in pull request #14314:
URL: https://github.com/apache/superset/pull/14314#discussion_r619301053
##########
File path:
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -163,6 +171,14 @@ export default function PluginFilterSelect(props:
PluginFilterSelectProps) {
</Option>
);
})}
+ {currentSuggestionSearch &&
+ !(values || []).some(
Review comment:
WDYT about using `ensureIsArray(values)` instead of `values || []`? I'm
not sure if it'd be easier to read, but maybe a bit safer in case `values` is
not an array
##########
File path:
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -150,6 +155,9 @@ export default function PluginFilterSelect(props:
PluginFilterSelectProps) {
showSearch={showSearch}
mode={multiSelect ? 'multiple' : undefined}
placeholder={placeholderText}
+ onSearch={val => setCurrentSuggestionSearch(val)}
Review comment:
```suggestion
onSearch={setCurrentSuggestionSearch}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
