hughhhh commented on a change in pull request #13521:
URL: https://github.com/apache/superset/pull/13521#discussion_r619367310
##########
File path: superset/sql_parse.py
##########
@@ -332,8 +332,9 @@ def set_or_update_query_limit(self, new_limit: int) -> str:
break
_, limit = statement.token_next(idx=limit_pos)
# Override the limit only when it exceeds the configured value.
- if limit.ttype == sqlparse.tokens.Literal.Number.Integer and new_limit
< int(
- limit.value
+ if force or (
+ limit.ttype == sqlparse.tokens.Literal.Number.Integer
Review comment:
is this suppose to be `type`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
