hughhhh commented on a change in pull request #14208:
URL: https://github.com/apache/superset/pull/14208#discussion_r618778914
##########
File path: superset/databases/api.py
##########
@@ -839,3 +841,67 @@ def function_names(self, pk: int) -> Response:
if not database:
return self.response_404()
return self.response(200, function_names=database.function_names,)
+
+ @expose("/available/", methods=["GET"])
Review comment:
With the current pattern, i'd rather it be separate endpoint vs. trying
to hotwire it into the database endpoint. It is cleaner for us to have
endpoint -> command this will also help with error handling in the future.
Would love to hear what @dpgaspar has to say
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
