AAfghahi commented on a change in pull request #13521:
URL: https://github.com/apache/superset/pull/13521#discussion_r619434712
##########
File path: superset/sql_lab.py
##########
@@ -245,7 +252,19 @@ def execute_sql_statement(
query.id,
str(query.to_dict()),
)
- data = db_engine_spec.fetch_data(cursor, query.limit)
+ data = db_engine_spec.fetch_data(cursor, increased_query)
+ if query.limit is None or len(data) <= query.limit:
+ query.limiting_factor = LimitingFactor.NOT_LIMITED
+ else:
+ data = data[:-1]
Review comment:
good call, added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
