krsnik93 commented on issue #14209: URL: https://github.com/apache/superset/issues/14209#issuecomment-826753034
> 1. Add tooltips to 'needles' **- p1** added in https://github.com/apache-superset/superset-ui/pull/1070/commits/62be2086c05483a08932d2869021f597801145d8 > 2. Add (dynamic)time range filter, not the entire time section **- p1** (4/17/2021 Time section is added, need to make it dynamic) All the other charts seem to use the entire time section, should we try to stay consistent? > 3. Percentage on scale p2 Due to the way echarts overlaps multiple series:  by not showing the full length of each progress line, I think displaying percentages does not make sense. The changes for this should be done in `echarts` and I don't know if the use case is strong enough. For percentages, I would say using the pie chart makes more sense. > 4. Detect the scale range if there are more than one series. right now default is set [0,100], and user have to change MAX for the chart the make sense I have made it so that both min and max are now dynamically determined. Max on the axis becomes 2 * max data value, min on the axis is smaller of 0 and 2 * min data value (this is useful for negatives). It's still possible for the user to pass these two explicitly, but they are now optional control panel args. > 1. Only up to four labels can be displayed when group-by is added, see the second screenshot above, we have the data of 7 regions from the query, but only showing 4. This depends on the font size. By reducing it to the smallest value on the slider, I was able to display 7 data points. One way would be to decrease space between two different titles/values, but I don't think it should be decreased further. If you look at the image the spacing is already quite compact: > <img alt="Screen Shot 2021-04-16 at 6 39 28 PM" width="477" src="https://user-images.githubusercontent.com/67837651/115098135-262a4000-9ee3-11eb-9f49-f56b3507d7ab.png";> > 2. After changing VALUE FORMAT in Custom tab, there's no way to restore the original value on the chart label. **- p1** I don't understand this argument completely. I actually don't like this control and think it should be replaced, perhaps with separate prefix and suffix fields, just to avoid having this template value in the input field. Maybe even dropped completely as manipulating the query can be used to achieve similar results and the other charts don't have this type of formatter. What do you think? > 3. All changes made in the CUSTOMIZE tab seems re-trigger query in the south data table which may affect perf **- p2** Currently all changes need to trigger, otherwise it's not possible to have a separate CUSTOMIZE tab and everything gets moved back to DATA tab: https://github.com/apache/superset/blob/77a9cc7088c421ff3d74cd8c54d7990a74b58bce/superset-frontend/src/explore/components/ControlPanelsContainer.tsx#L277 > 4. When SHOW PROGRESS box is checked in Customize, and there are multiple series after group-by, user is only able to see up to 2 values. Those 2 should not be related. Control `splitNumber` should be used to set number of splits/labels. If there is an overlap this could be fixed in https://github.com/apache-superset/superset-ui/pull/1056 > 1. Changing dataset should reset control panel to default, and set chart to the original state, only leaves COUNT(*) in metric. Isn't this constant for all chart types? > > Cosmetic issue > Overlapping here and there > > 1. in Show Progress and Round Cap > > > <img alt="Screen Shot 2021-04-16 at 6 54 42 PM" width="530" src="https://user-images.githubusercontent.com/67837651/115098501-3ba06980-9ee5-11eb-8e5d-fe7518edd6ff.png";> Regarding labels, this is fixed in https://github.com/apache-superset/superset-ui/pull/1056 as well. Regarding values in the middle, I don't know if anything can be done besides reducing the font size and perhaps utilizing row limit and adhoc filters. Giving the chart more space on the dashboard might help as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/67837651/115098135-262a4000-9ee3-11eb-9f49-f56b3507d7ab.png"](https://user-images.githubusercontent.com/67837651/115098135-262a4000-9ee3-11eb-9f49-f56b3507d7ab.png"){kind=link}
![https://user-images.githubusercontent.com/67837651/115098501-3ba06980-9ee5-11eb-8e5d-fe7518edd6ff.png"](https://user-images.githubusercontent.com/67837651/115098501-3ba06980-9ee5-11eb-8e5d-fe7518edd6ff.png"){kind=link}