amitmiran137 commented on pull request #14261: URL: https://github.com/apache/superset/pull/14261#issuecomment-827314677
> I would like to avoid adding a database migration for this. > > If some dashboard owners would like to remove the filter bar from their dashboards, it makes sense to add a metadata json option that they can set, but setting it as the default seems like overkill. Especially so when the native filters are already behind a feature flag in the first place. > > Side note: There are also efforts underway to build an option for dashboard owners to auto-migrate from filter box to native filters, so the issue of having filter boxes hanging around will hopefully be short lived. > > Side note 2: In the case where a non-editor is viewing a dashboard that has no native filters, it might be better to not show the filter bar since it will just be empty. I think I'm going to replace the migration with side note 2 That would accomplish exactly the use of showing the filter bar when it is not relevant Thanks for that ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
