michael-s-molina commented on a change in pull request #14048:
URL: https://github.com/apache/superset/pull/14048#discussion_r621121103
##########
File path:
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx
##########
@@ -68,35 +67,29 @@ const DashboardContainer: FC<DashboardContainerProps> = ({
the entire dashboard upon adding/removing top-level tabs, which
would otherwise
happen because of React's diffing algorithm
*/
- <TabContainer
+ <Tabs
id={DASHBOARD_GRID_ID}
- activeKey={Math.min(tabIndex, childIds.length - 1)}
- onSelect={handleChangeTab}
- // @ts-ignore
- animation
- mountOnEnter
- unmountOnExit={false}
+ activeKey={activeKey}
+ renderTabBar={() => <></>}
Review comment:
Yes because `Tabs` renders a default `tabBar` with predefined height and
margin as you can see below:
<img width="1126" alt="Screen Shot 2021-04-27 at 8 30 58 AM"
src="https://user-images.githubusercontent.com/70410625/116234439-fbd25100-a732-11eb-8f64-dbee6a0202e0.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/70410625/116234439-fbd25100-a732-11eb-8f64-dbee6a0202e0.png"](https://user-images.githubusercontent.com/70410625/116234439-fbd25100-a732-11eb-8f64-dbee6a0202e0.png"){kind=link}