zuzana-vej commented on pull request #14298: URL: https://github.com/apache/superset/pull/14298#issuecomment-827744396
I agree that sometimes limit is intentional and then it shouldn't be a warning. However the 1000 limit is default, many users don't realize this, and they query the data, sort through the displayed table not seeing what expected, or they download to CSV only to realize that they only downloaded 1000 records and they need to rerun the query again. Based on this user feedback, when the 1000 limit was applied due to the default dropdown it should be a warning. If there is N rows displayed because the query simply just returned 345 records, then I agree it shouldn't be a warning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
