john-bodley commented on pull request #14366: URL: https://github.com/apache/superset/pull/14366#issuecomment-827899928
@villebro any thoughts as to why CI may be failing? I've been wrangling with this for hours, descoping the impact of the change as I go. Note it seems like the test hardness is failing on `tests/queries/api_tests.py` though passes when run separately, i.e., ``` tox -e py38-sqlite -- tests/queries/api_tests.py ``` which would possibly indicate some leakage, however I've gone over the change a number of times and can't see what the issue could be. For example I renamed the fixture I added from `app` to `test_app` to now `app_` to make sure there's no conflict with the whole `tests.test_app.app` yuckiness which gets imported (in various ways) and is used in a number of fixtures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
