rusackas commented on pull request #14184: URL: https://github.com/apache/superset/pull/14184#issuecomment-828141854
These inconsistencies between sections of Superset are due to there being two React apps in a single page (one for the Menu and one for the rest of the page/content). There were multiple instantiations of Emotion packages in these situations, and this can be remedied via Emotion's `CacheProvider` package which will allow us to appropriately namespace these generated classes. Also, we want to make sure we're properly exporting all Emotion bits from Superset-UI so that they're imported in Superset consistently. This will lead to a little series of PRs: 1) Adding/updating exports in Superset UI. PR [here](https://github.com/apache-superset/superset-ui/pull/1073). 2) Pulling in that package in Superset, and utilizing `CacheProvider` 3) Rebasing/merging this PR. 4) Making sure ALL Emotion scripts are imported via Superset-UI, removing Emotion packages from Superset, and adding an ESLint rule to forbid the use of the Emotion packages directly. 5) Continuing work to get rid of the multi-React-app issue (i.e. making Superset a Single Page App and deprecating legacy FAB views) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
