junlincc commented on issue #13442:
URL: https://github.com/apache/superset/issues/13442#issuecomment-828678261
My understanding of this project
- The company(multiple companies) wants to integrate Superset as analytics
charting tool as part of their existing multi-lingual solution/application.
- Only admin/internal users can edit the language modal(see mockup above)
- Only admin/internal users can add new languages (e.g. English, Chinese,
Spanish, Hindi) and translation to chart UI component fields (e.g. title,
metric, legend and axis)
- Selecting the language at global level (on the top right) also change
language setting at the chart level(e.g. if admin/internal user select Spanish
as UI language, all chart component UI is in Spanish as well)
- Admin/internal users publish the localized dashboards/chart in selected
language to public
- Public user will not be able to select language or edit the language
modal.
@mistercrunch so to some degree, this case is related to Embedded(not
embedded Explore page)
From a product standpoint, it may seem like an edge case, but I have
received similar request before, so the needs are validated. As long as it's
developed behind a feature flag, I don't see much downside of the project, in
terms of affecting major developments in Explore or Explore UI.
In terms of priority, `1.` definitely have a higher impact and needs more
work. There are a few proposed roadmap items that can benefit this effort in
general, as an OSS project
Proposed Functionality
Step 1: Clean up all concatenated translation strings
Step 1.5 (Optional): Update i18n solution, make it possible to fallback to
English translated strings.
Step 2: Replace all translation keys with unique, contextualized keys. E.g.
_('global.menu.Charts')
listed in https://github.com/apache-superset/superset-roadmap/issues/153
@ktmud
@thelightbird
Though 1 and 2 may target different use cases and personas, as an OSS
project, we would appreciate some contribution towards `1. ` before or in
parallel with `2. ` to improve localization in general in Superset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
