ktmud commented on issue #13442: URL: https://github.com/apache/superset/issues/13442#issuecomment-828892128
Note that for viz plugins, it is possible to add all translations within the plugin itself ([example](https://github.com/ktmud/superset-ui/blob/master/plugins/plugin-chart-table/src/i18n.ts )), which is then loaded only when the specific viz type is rendered. This should be the recommended way of adding UI-element translations for viz plugins since it makes it easier to migrate to dynamically-loaded plugins. As to the request in this SIP, I can understand the needs but the proposed solution really sound worrisome because it is not just adding a new feature, but also replacing existing UI elements and changing db schema and API. Even if things are behind a feature flag, there will be substantial maintenance costs. I wonder if there are less intrusive ways to do more or less the same. For example, Tableau recommends users to create multiple worksheets for different languages then use tabs and links to help users select languages : https://www.tableau.com/about/blog/2016/4/how-create-multilingual-dashboards-52933 Superset users can already do the same, albeit having different charts for different languages makes it more difficult to sync changes between languages. However, currently you can already override Chart titles in the dashboard editor: <img width="720" alt="Xnip2021-04-28_18-53-00" src="https://user-images.githubusercontent.com/335541/116493169-fa984580-a852-11eb-8304-801eb0f761fd.png";> which means, the only missing piece for users to re-use the same chart in dashboards in different languages is to add more dashboard-level overrides than will not only change the slice name, but also the text fields in chart metadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/335541/116493169-fa984580-a852-11eb-8304-801eb0f761fd.png"](https://user-images.githubusercontent.com/335541/116493169-fa984580-a852-11eb-8304-801eb0f761fd.png"){kind=link}