rusackas commented on pull request #14318: URL: https://github.com/apache/superset/pull/14318#issuecomment-828968739
I'm SO tempted to merge this... I think the code LGTM. One minor naming nit remains as an open comment. The bigger issue is perf testing: 1) Is there a flash of blank-icons and then icons slowly appearing on screen if there are a whole bunch of them being lazy-loaded? 2) Is there indeed a smaller bundle when using this dynamic import technique vs the "import ever svg into the component" plan? I would assume so, but it'd be nice to verify. You might be able to do `npm run build -- --analyzeBundle=true` to get an idea of this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
