betodealmeida commented on a change in pull request #14416:
URL: https://github.com/apache/superset/pull/14416#discussion_r623388719
##########
File path: tests/db_engine_specs/mysql_tests.py
##########
@@ -110,7 +110,7 @@ def test_extract_errors(self):
"""
Test that custom error messages are extracted correctly.
"""
- msg = "mysql: Access denied for user 'test'@'testuser.com'. "
+ msg = "mysql: Access denied for user 'test'@'testuser.com' "
Review comment:
```suggestion
msg = "mysql: Access denied for user 'test'@'testuser.com'"
```
##########
File path: tests/db_engine_specs/mysql_tests.py
##########
@@ -196,7 +196,7 @@ def test_extract_errors(self):
)
]
- msg = "mysql: Unknown database 'badDB'."
+ msg = "mysql: Unknown database 'badDB'.ß"
Review comment:
```suggestion
msg = "mysql: Unknown database 'badDB'"
```
##########
File path: superset/db_engine_specs/mysql.py
##########
@@ -42,13 +42,13 @@
# Regular expressions to catch custom errors
CONNECTION_ACCESS_DENIED_REGEX = re.compile(
- "Access denied for user '(?P<username>.*?)'@'(?P<hostname>.*?)'. "
+ "Access denied for user '(?P<username>.*?)'@'(?P<hostname>.*?)' "
Review comment:
```suggestion
"Access denied for user '(?P<username>.*?)'@'(?P<hostname>.*?)'"
```
##########
File path: tests/db_engine_specs/mysql_tests.py
##########
@@ -135,7 +135,7 @@ def test_extract_errors(self):
)
]
- msg = "mysql: Unknown MySQL server host 'badhostname.com'. "
+ msg = "mysql: Unknown MySQL server host 'badhostname.com' "
Review comment:
```suggestion
msg = "mysql: Unknown MySQL server host 'badhostname.com'"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
