michael-s-molina commented on a change in pull request #14424:
URL: https://github.com/apache/superset/pull/14424#discussion_r623809132
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -50,6 +52,44 @@ interface DatabaseModalProps {
const DEFAULT_TAB_KEY = '1';
+const StyledDBModal = styled(StyledModal)`
+ .ant-alert {
+ margin-top: ${({ theme }) => theme.gridUnit * 4}px;
+ color: #325D7E;
Review comment:
I saw that you're using `Alert` `info`. Why are you changing the default
`color`, `fontSize` and `border`? I'm worried that we'll have a lack of theme
consistency.
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -50,6 +52,44 @@ interface DatabaseModalProps {
const DEFAULT_TAB_KEY = '1';
+const StyledDBModal = styled(StyledModal)`
+ .ant-alert {
+ margin-top: ${({ theme }) => theme.gridUnit * 4}px;
+ color: #325D7E;
+ border: 1px solid #66BCFE;
+ font-size: 13px;
+ padding: 15px;
Review comment:
```suggestion
padding: ${({ theme }) => theme.gridUnit * 4}px;
```
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -50,6 +52,44 @@ interface DatabaseModalProps {
const DEFAULT_TAB_KEY = '1';
+const StyledDBModal = styled(StyledModal)`
+ .ant-alert {
+ margin-top: ${({ theme }) => theme.gridUnit * 4}px;
+ color: #325D7E;
+ border: 1px solid #66BCFE;
+ font-size: 13px;
+ padding: 15px;
+ }
+
+ .ant-alert-message {
+ color: #325D7E;
+ font-weight: bold;
+ }
+
+ .ant-modal-body {
+ padding-top: 0;
+ }
+`;
+
+const Header = styled.div`
+ display: flex;
+ flex-direction: column;
+ justify-content: center;
+ padding: ${({ theme }) => theme.gridUnit * 4}px;
+ margin-bottom: 16px;
Review comment:
```suggestion
margin-bottom: ${({ theme }) => theme.gridUnit * 4}px;
```
##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -50,6 +52,44 @@ interface DatabaseModalProps {
const DEFAULT_TAB_KEY = '1';
+const StyledDBModal = styled(StyledModal)`
+ .ant-alert {
+ margin-top: ${({ theme }) => theme.gridUnit * 4}px;
+ color: #325D7E;
+ border: 1px solid #66BCFE;
+ font-size: 13px;
+ padding: 15px;
+ }
+
+ .ant-alert-message {
+ color: #325D7E;
+ font-weight: bold;
+ }
+
+ .ant-modal-body {
+ padding-top: 0;
+ }
+`;
+
+const Header = styled.div`
+ display: flex;
+ flex-direction: column;
+ justify-content: center;
+ padding: ${({ theme }) => theme.gridUnit * 4}px;
+ margin-bottom: 16px;
+`;
+
+const HeaderTitle = styled.div`
+ color: ${({ theme }) => theme.colors.grayscale.dark1} !important;
Review comment:
Can you try to avoid `!important`? Maybe use a more specific class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
