rusackas commented on a change in pull request #14356:
URL: https://github.com/apache/superset/pull/14356#discussion_r624255976
##########
File path: superset-frontend/src/components/ListViewCard/index.tsx
##########
@@ -169,13 +182,14 @@ function ListViewCard({
imgPosition = 'top',
cover,
}: CardProps) {
+ const Link = url && linkComponent ? linkComponent : AnchorLink;
return (
<StyledCard
data-test="styled-card"
cover={
cover || (
<Cover>
- <a href={url}>
+ <Link to={url!}>
Review comment:
Maybe we can adda. test to make sure this renders as expected
with/without the url?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
