nytai commented on a change in pull request #14434:
URL: https://github.com/apache/superset/pull/14434#discussion_r624315972
##########
File path: Makefile
##########
@@ -47,3 +47,8 @@ pre-commit:
# setup pre commit dependencies
pip3 install -r requirements/integration.txt
pre-commit install
+
+prettier:
Review comment:
can we call it `prettier` and `black` so it's clear which tool is
actually running? Or `js-format` and `py-format`? Prettier supports various
file types, and there's a [python
plugin](https://github.com/prettier/plugin-python), so it may be a bit
confusing which tool is running and needs to be installed. Trying to avoid any
"py-prettier is failing even though I have prettier installed" issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
