amitmiran137 commented on a change in pull request #14441:
URL: https://github.com/apache/superset/pull/14441#discussion_r624669161
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -186,6 +189,8 @@ export const FiltersConfigForm:
React.FC<FiltersConfigFormProps> = ({
formFilter?.filterType,
);
+ const isCascadingFilter = CASCADING_FILTERS.includes(formFilter?.filterType);
Review comment:
```suggestion
const isCascadingFilterAllowed =
CASCADING_FILTERS.includes(formFilter?.filterType);
```
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -417,20 +422,22 @@ export const FiltersConfigForm:
React.FC<FiltersConfigFormProps> = ({
hidden
initialValue={null}
/>
- <StyledFormItem
- name={['filters', filterId, 'parentFilter']}
- label={<StyledLabel>{t('Parent filter')}</StyledLabel>}
- initialValue={parentFilterOptions.find(
- ({ value }) => value === filterToEdit?.cascadeParentIds[0],
- )}
- data-test="parent-filter-input"
- >
- <Select
- placeholder={t('None')}
- options={parentFilterOptions}
- isClearable
- />
- </StyledFormItem>
+ {isCascadingFilter && (
Review comment:
```suggestion
{isCascadingFilterAllowed && (
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
