villebro opened a new pull request #14446: URL: https://github.com/apache/superset/pull/14446
### SUMMARY Follow-up to #14408, which was supposed to include a db migration, but it got lost in the shuffle. This PR performs a migration to upgrade native filter and filter set metadata to correspond with the new perf improved metadata. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [x] Migration is atomic, supports rollback & is backwards-compatible - [x] Confirm DB migration upgrade and downgrade tested - [xx] Runtime estimates and downtime expectations provided (see below) - [ ] Introduces new feature or API - [ ] Removes existing feature or API ``` $ python scripts/benchmark_migration.py superset/migrations/versions/f1410ed7ec95_migrate_native_filters_to_new_schema.py --limit 1000000 Results: Current: 0.29 s 10+: 0.24 s 100+: 0.23 s 1000+: 0.23 s 10000+: 0.37 s 100000+: 0.33 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
