etr2460 opened a new pull request #14450: URL: https://github.com/apache/superset/pull/14450
### SUMMARY My previous etag PR (#14357) broke creating new dashboards because they wouldn't have any slices or datasets associated with them yet, thus running `max([])` which fails. This sets a min bound for the changed_on time to unixtime 0 which should be safe. ### TEST PLAN :eyes: and CI ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API to: @graceguo-supercat @ktmud @suddjian @john-bodley -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
