etr2460 opened a new pull request #14471: URL: https://github.com/apache/superset/pull/14471
### SUMMARY Mypy types led me astray and proved that `dashboard.datasources` was actually a `Set[Optional[BaseDatasource]]`. I've updated logic to filter out None datasources for dashboards, updated the types to be correct, and handle `slice.datasource == None` throughout the app ### TEST PLAN CI ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API to: @villebro @john-bodley @graceguo-supercat @ktmud @suddjian -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
