michellethomas opened a new pull request #14476: URL: https://github.com/apache/superset/pull/14476
### SUMMARY I'd like to log requests to the /datasource/save endpoint so that we know when users alter a datasource. One question I have is whether we care if we are logging large data blobs in the json field. The data that automatically gets logged in the `json` column can be large (it includes all of the data for the datasource that is getting saved so if the datasource has a lot of columns they will all get logged). I didn't see any situations where we are altering the data that gets logged (except for changing the action field), does it matter if we log large json payloads to the logs table? ### TEST PLAN Edited a datasource from the `/tablemodelview/list/` and explore pages, confirmed logs in the logs table. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API @john-bodley @etr2460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
