suddjian commented on a change in pull request #14464:
URL: https://github.com/apache/superset/pull/14464#discussion_r626187391
##########
File path:
superset-frontend/cypress-base/cypress/integration/dashboard/dashboard.helper.ts
##########
@@ -110,8 +119,8 @@ export function drag(selector: string, content: string |
number | RegExp) {
(typeof target === 'string' ? cy.get(target) : target)
.trigger('dragover', { dataTransfer })
.trigger('drop', { dataTransfer })
- .trigger('dragend', { dataTransfer })
- .trigger('mouseup', { which: 1 });
+ .trigger('dragend', { dataTransfer, force: true })
+ .trigger('mouseup', { which: 1, force: true });
Review comment:
this handles cases where dragging something onto a drop target causes
the drop target to become covered by new elements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
