geido opened a new pull request #14492: URL: https://github.com/apache/superset/pull/14492
### SUMMARY I could not reproduce the issue described in #13158. However, I am adding this extra check in the part of the code that was causing the problem originally in case it might help to stop the issue from happening in other places. ### CURRENT MASTER BEHAVIOR [Watch the video](https://www.awesomescreenshot.com/video/3633371?key=4b744f8cd2cbc26b92dcf3146d42db6e) ### TEST PLAN 1. Create a new dashboard or open an existing one 2. Add new tabs 3. Without moving focus to the tab you are willing to delete, click on the "X" to delete it 4. Confirm the deletion 5. Observe that the modal is closed and the tab deleted successfully ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #13158 - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
