villebro commented on a change in pull request #14461:
URL: https://github.com/apache/superset/pull/14461#discussion_r627180202
##########
File path: superset-frontend/src/filters/components/GroupBy/controlPanel.ts
##########
@@ -37,6 +37,7 @@ const config: ControlPanelConfig = {
type: 'CheckboxControl',
label: t('Multiple select'),
default: multiSelect,
+ affectDataMask: true,
Review comment:
nit: maybe rename to `affectsDataMask`
##########
File path: superset-frontend/src/dashboard/actions/nativeFilters.ts
##########
@@ -74,6 +74,7 @@ export const setFilterConfiguration = (
filterConfig,
});
const { id, metadata } = getState().dashboardInfo;
+ const oldFilters = getState().nativeFilters?.filters;
Review comment:
Why is this called `oldFilters`? Shouldn't this be `newFilters`?
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -449,6 +451,10 @@ export const FiltersConfigForm:
React.FC<FiltersConfigFormProps> = ({
form={form}
formData={newFormData}
/>
+ ) : hasFilledDataset ? (
+ t('Click "Populate" to get "Default Value" ->')
+ ) : (
+ t('Fill all required field to enable "Default Value"')
Review comment:
nit:
```suggestion
t('Fill all required fields to enable "Default Value"')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
