villebro commented on a change in pull request #14493:
URL: https://github.com/apache/superset/pull/14493#discussion_r627470237
##########
File path:
superset-frontend/cypress-base/cypress/integration/explore/control.test.ts
##########
@@ -111,7 +111,7 @@ describe('VizType control', () => {
// should load mathjs for line chart
cy.get('script[src*="mathjs"]').should('have.length', 1);
cy.get('script').then(nodes => {
- expect(nodes.length).to.eq(numScripts);
+ expect(nodes.length).to.greaterThan(numScripts);
Review comment:
I wasn't able to reproduce this locally (locally I was only getting 11
script nodes, but cypress is finding `nodes.length === 13`, `numScripts ===
12`), but I noticed that this used to be `greaterThan` before this PR: #12218 ,
so I assume this can be flipped back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
