geido commented on a change in pull request #14462:
URL: https://github.com/apache/superset/pull/14462#discussion_r627546810
##########
File path: superset-frontend/src/views/CRUD/data/dataset/AddDatasetModal.tsx
##########
@@ -107,7 +109,7 @@ const DatasetModal: FunctionComponent<DatasetModalProps> =
({
show={show}
title={
<>
- <StyledIcon name="warning-solid" />
+ <StyledIcon iconColor={theme.colors.grayscale.base} />
Review comment:
Hey @pkdotson same comment as the other PR. What's making defining the
color specifically for the icon necessary here? The icon should get the color
from the container
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
