geido commented on a change in pull request #14364:
URL: https://github.com/apache/superset/pull/14364#discussion_r627561095
##########
File path: superset-frontend/src/profile/components/App.tsx
##########
@@ -41,62 +45,46 @@ export default function App({ user }: AppProps) {
</Col>
<Col xs={24} md={18}>
<Tabs centered>
- <Tabs.TabPane
+ <StyledTabPane
key="1"
Review comment:
I know this isn't part of this PR specifically and it's really just a
nit but since we are here it would be cool to use non-numeric keys. We could
use humanly readable keys with the names of the tabs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
