zhaoyongjie commented on a change in pull request #14478:
URL: https://github.com/apache/superset/pull/14478#discussion_r627899551
##########
File path:
superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/index.jsx
##########
@@ -348,6 +348,7 @@ export default class AdhocMetricEditPopover extends
React.PureComponent {
className="adhoc-metric-edit-tabs"
style={{ height: this.state.height, width: this.state.width }}
onChange={this.onTabChange}
+ animated={false}
Review comment:
same before nit
##########
File path:
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.jsx
##########
@@ -162,6 +162,7 @@ export default class AdhocFilterEditPopover extends
React.Component {
data-test="adhoc-filter-edit-tabs"
style={{ minHeight: this.state.height, width: this.state.width }}
allowOverflow
+ animated={false}
Review comment:
animated default value is `false`, so `animated` could be deleted here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
