villebro opened a new pull request #14539: URL: https://github.com/apache/superset/pull/14539
### SUMMARY Many NVD3 timeseries viz' were featured duplicated sorting logic that was missing from others. This introduces sorting logic to the base `NVD3TimeSeriesViz` class removes the same from the following viz': - `NVD3TimeSeriesStackedViz` (=area chart) - `HorizonViz` - `RoseViz` - `PartitionViz` By moving the sorting logic to the base class, this logic is now added to the following chart types that were previously missing it: - `NVD3TimeSeriesViz` (=line chart) - `NVD3TimeSeriesBarViz` - `NVD3CompareTimeSeriesViz` The following charts that extend the `NVD3TimeSeriesViz` are unaffected, since they don't feature the sorting control: - `NVD3TimePivotViz` ### TEST PLAN All eight charts that this PR affects were manually tested to ensure that they work as expected. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
