villebro commented on a change in pull request #14487: URL: https://github.com/apache/superset/pull/14487#discussion_r629251034
########## File path: superset/migrations/versions/1a51759ec9f2_fix_slices_datasource_type.py ########## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""fix slices datasource type + +Revision ID: 1a51759ec9f2 +Revises: 67da9ef1ef9c +Create Date: 2021-05-05 11:29:23.912475 + +""" + +# revision identifiers, used by Alembic. +revision = '1a51759ec9f2' +down_revision = '67da9ef1ef9c' + +from alembic import op +import sqlalchemy as sa +from sqlalchemy.dialects import mysql + + +def upgrade(): + op.alter_column('slices', 'datasource_type', + existing_type=mysql.VARCHAR(length=200), + nullable=False) + + +def downgrade(): + op.alter_column('slices', 'datasource_type', + existing_type=mysql.VARCHAR(length=200), Review comment: Same here ########## File path: superset/migrations/versions/1a51759ec9f2_fix_slices_datasource_type.py ########## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""fix slices datasource type + +Revision ID: 1a51759ec9f2 +Revises: 67da9ef1ef9c +Create Date: 2021-05-05 11:29:23.912475 + +""" + +# revision identifiers, used by Alembic. +revision = '1a51759ec9f2' +down_revision = '67da9ef1ef9c' + +from alembic import op +import sqlalchemy as sa +from sqlalchemy.dialects import mysql + + +def upgrade(): + op.alter_column('slices', 'datasource_type', + existing_type=mysql.VARCHAR(length=200), Review comment: We support other databases than MySQL for the metadata database. This should be the generic String type, i.e. `sqlalchemy.String(200)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
