villebro opened a new pull request #14547:
URL: https://github.com/apache/superset/pull/14547


   ### SUMMARY
   Adds the generic datatype to the dataset column payload to avoid having to 
parse the raw datatypes in the frontend. 
   Dependent on https://github.com/apache-superset/superset-ui/pull/1102
   
   ### BEFORE
   Currently the numeric datatypes on the FCC 2018 example dataset show up as 
unidentified due to the frontend not being able to detect the generic datatype 
of the raw datatype from the database ("DOUBLE PRECISION"):
   
![image](https://user-images.githubusercontent.com/33317356/117661443-0d8e0c80-b1a7-11eb-9b6a-bed2b92d225c.png)
   
   ### AFTER
   Now numeric types are being picked up automatically. In the future only 
datatypes that the db engine spec doesn't identify are shown as question marks:
   
![image](https://user-images.githubusercontent.com/33317356/117661260-cc95f800-b1a6-11eb-8b06-80088e4606d0.png)
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to