[GitHub] [superset] geido opened a new pull request #14551: fix: Column name and icons alignment in the Datasource Panel (Explore)

[GitBox]

geido opened a new pull request #14551:
URL: https://github.com/apache/superset/pull/14551


   ### SUMMARY
   Fixes #13449 by changing the alignment of the column name and icons in the 
Datasource Panel.
   
   
   ### BEFORE
   <img width="1680" alt="before" 
src="https://user-images.githubusercontent.com/60598000/117692321-9451e200-b1c5-11eb-84ae-7118b17aeea8.png";>
   
   ### AFTER
   <img width="1628" alt="after_ellipsis" 
src="https://user-images.githubusercontent.com/60598000/117692342-9a47c300-b1c5-11eb-8dc1-d2ff4daa26a1.png";>
   
   
   ### TEST PLAN
   1. Open a chart in Explore
   2. Edit the dataset and change the label of a column with a very long one
   3. Make sure that the left icons, the column name, and tooltip icon are 
showing on the same line and that the column name cuts with ellipsis
   4. Make sure the responsive behavior works when the Datasource panel width 
is increased/decreased
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #13449
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org