hughhhh commented on a change in pull request #14420:
URL: https://github.com/apache/superset/pull/14420#discussion_r629526135
##########
File path: superset/databases/api.py
##########
@@ -905,3 +909,55 @@ def available(self) -> Response:
)
return self.response(200, databases=available_databases)
+
+ @expose("/validate_parameters", methods=["POST"])
+ @protect()
+ @statsd_metrics
+ @event_logger.log_this_with_context(
+ action=lambda self, *args, **kwargs: f"{self.__class__.__name__}"
+ f".validate_parameters",
+ log_to_statsd=False,
+ )
+ def validate_parameters( # pylint: disable=too-many-return-statements
+ self,
+ ) -> FlaskResponse:
+ """validates database connection parameters
+ ---
+ post:
+ description: >-
+ Validates parameters used to connect to a database
+ requestBody:
+ description: DB-specific parameters
+ required: true
+ content:
+ application/json:
+ schema:
+ $ref: "#/components/schemas/DatabaseValidateParametersSchema"
+ responses:
+ 200:
+ description: Database Test Connection
+ content:
+ application/json:
+ schema:
+ type: object
+ properties:
+ message:
+ type: string
+ 400:
+ $ref: '#/components/responses/400'
+ 422:
+ $ref: '#/components/responses/422'
+ 500:
+ $ref: '#/components/responses/500'
+ """
+ if not request.is_json:
+ raise InvalidPayloadFormatError("Request is not JSON")
+
+ try:
+ payload = DatabaseValidateParametersSchema().load(request.json)
+ except ValidationError as error:
+ raise InvalidPayloadSchemaError(error)
+
+ command = ValidateDatabaseParametersCommand(g.user, payload)
+ command.run()
Review comment:
Can we put this into the try catch as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
