geido commented on a change in pull request #14566:
URL: https://github.com/apache/superset/pull/14566#discussion_r630232874
##########
File path: superset-frontend/stylesheets/superset.less
##########
@@ -603,7 +603,3 @@ hr {
top: 269px !important;
}
}
-
-.ant-dropdown.ant-dropdown-placement-bottomRight {
- top: 133px !important;
Review comment:
@pkdotson this was introduced by PR #14184. Not sure what side effects
might have removing it, but in general it seems that the approach of forcing
the positions might not be the right one in the first place.
The potential issues were also reported by @rusackas on this review comment
https://github.com/apache/superset/pull/14184/files#r626190039 but were then
overlooked. I would please ask you to have a look at that portion of the
changes and find different solutions. I am pretty sure this is not the only
issue that we might face.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
