rusackas commented on a change in pull request #14582:
URL: https://github.com/apache/superset/pull/14582#discussion_r630662455
##########
File path: superset-frontend/src/components/Alert/index.tsx
##########
@@ -60,12 +63,13 @@ export default function Alert(props: AlertProps) {
icon={<AlertIcon aria-label={`${type} icon`} />}
closeText={closable && <Icon name="x-small" aria-label="close icon" />}
css={{
- padding: '6px 10px',
+ marginBottom: roomBelow ? gridUnit * 4 : 0,
+ padding: `${gridUnit * 2}px ${gridUnit * 3}px`,
alignItems: 'flex-start',
border: 0,
backgroundColor: baseColor.light2,
'& .ant-alert-icon': {
- marginRight: 10,
+ marginRight: gridUnit * 2,
Review comment:
Happened to see some pixel measurements in here that I figured I might
as well convert to gridUnits while we're in here. Trying to keep bycatch
minimal these days, but... I couldn't help myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
