villebro commented on a change in pull request #14547:
URL: https://github.com/apache/superset/pull/14547#discussion_r630827978
##########
File path: superset/connectors/base/models.py
##########
@@ -533,6 +533,7 @@ class BaseColumn(AuditMixinNullable, ImportExportMixin):
def __repr__(self) -> str:
return str(self.column_name)
+ bool_types = ("BOOL",)
Review comment:
Actually these aren't really used anywhere, it's just a fallback for
non-SQLA connectors; the models in `sqla/models.py` file checks these directly
from the relevant db engine spec, hence the relevant definitions are defined in
`BaseEngineSpec` and can be overridden on an engine-by-engine basis.
These could actually be removed, but I'd prefer not to do it in this PR to
avoid possible breakage to the Druid REST model.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
