rusackas commented on pull request #14587: URL: https://github.com/apache/superset/pull/14587#issuecomment-839962033
Code looks simple enough... easy review! Waiting on the ephemeral build to verify. Two questions for @pkdotson: 1) Was it tested with and without the Native Filters feature flag enabled? 2) Can you think of any sort of regression test we can add here? RTL's `toBeVisible` doesn't seem sufficient here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
