eschutho commented on a change in pull request #14451:
URL: https://github.com/apache/superset/pull/14451#discussion_r631311874
##########
File path: superset/databases/commands/update.py
##########
@@ -75,12 +75,21 @@ def validate(self) -> None:
if not self._model:
raise DatabaseNotFoundError()
database_name: Optional[str] = self._properties.get("database_name")
+ configuration_method: Optional[str] = self._properties.get(
Review comment:
we update on the second step on save as well, so all we have is the post
response to go by, and so we don't pass the configuration method with it. it's
not possible for the row to have a none value, but since we don't currently
update that value, it's possible for the update request not to pass the
configuration method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
