etr2460 opened a new pull request #14593:
URL: https://github.com/apache/superset/pull/14593


   ### SUMMARY
   Transforming to uppercase for the form label in FilterBoxes is problematic 
because the filter column names are case sensitive.  This should make the 
labels match the actual case of the column name
   
   This might look a bit worse than the current experience, but i think it's 
necessary because it can hide a really ugly bug when the columns don't apply to 
vizes because the case of a column is different
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   TODO
   
   ### TEST PLAN
   visual inspection
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to