eschutho commented on a change in pull request #14535:
URL: https://github.com/apache/superset/pull/14535#discussion_r631457745



##########
File path: superset/db_engine_specs/base.py
##########
@@ -271,6 +272,17 @@ class BaseEngineSpec:  # pylint: 
disable=too-many-public-methods
     run_multiple_statements_as_one = False
     custom_errors: Dict[Pattern[str], Tuple[str, SupersetErrorType]] = {}
 
+    # schema describing the parameters used to configure the DB
+    parameters_schema: Schema = None
+
+    # recommended driver name for the DB engine spec
+    drivername: str = ""
+
+    # placeholder with the SQLAlchemy URI template
+    sqlalchemy_uri_placeholder = (
+        "drivername://user:password@host:port/dbname[?key=value&key=value...]"

Review comment:
       we'll want to customize this string placeholder for BigQuery since we 
can do that now. :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to